Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose @alexagriffith initial approver of serving-progressive-rollout #1472

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Propose @alexagriffith initial approver of serving-progressive-rollout #1472

merged 3 commits into from
Nov 30, 2023

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Nov 30, 2023 •
edited
Loading

Changes

  • @alexagriffith will be the code reviewer of the implementation for the progressive rollout feature, as the implementation start to go out.

/kind

Release Note

Docs

@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 30, 2023

@houshengbo: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • @alexagriffith will be the code reviewer of the implementation for the progressive rollout feature, as the implementation start to go out.

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 30, 2023
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@knative-prow knative-prow bot merged commit 8073ad3 into knative:main Nov 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhadas davidhadas Awaiting requested review from davidhadas

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@houshengbo @dprotaso